Initialise reason="connect-timeout" series for cache operation_failures_total metric
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_failures_total` metric
charleskorn
changed the title
reason="connect-timeout" series for memcached operation_failures_total metricreason="connect-timeout" series for cache operation_failures_total metric
charleskorn
force-pushed
the
charleskorn/memcached-metrics
branch
from
4e588d4 to
74a82ad
Compare
flxbk
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the missing initialisation of the value of the
operation_failures_total{reason="connect-timeout"}metric series for each cache operation type.This ensures that the first failure due to connection timeout after a restart is observable with the
rate()PromQL function.All of the other
reasonvalues emitted bybaseClient.trackError()are initialised to 0 at startup, this was the only missing one.Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]