Extract route name logic to a single middleware and use it everywhere #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
May 27, 2024
| @@ -31,6 +31,7 @@ type contextKey int | |||
|
|
|||
| const ( | |||
| contextKeyMethodName contextKey = 1 | |||
| contextKeyRouteName contextKey = 2 | |||
There was a problem hiding this comment.
nit: move to route_injector.go?
There was a problem hiding this comment.
I wanted to keep all the contextKey values in one place, as otherwise there's a risk that we define two contextKeys with the same value (eg. two contextKeys with value 3).
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduces a new HTTP middleware,
RouteInjector, that extracts and stores the active request's route name for use in telemetry.This route name can then be used in traces, metrics and logs. The existing tracing and metrics middlewares have been updated to use this single source of the route name, and applications can call
middleware.ExtractRouteNameto include the route name in logs when appropriate.Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]