Add YAML unmarshalers for Alertmanager configuration structs #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santihernandezc
changed the title
stevesg
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
UnmarshalYAML()methods for theConfigandPostableApiAlertingConfigstructs. It also addsUnmarshalJSON()toPostableApiReceiver. Json unmarshallers for these structs make use of their respective yaml counterparts, the goal is to get to the same data either from yaml or json.Being able to parse YAML configuration into
PostableApiAlertingConfigwill enable us to use this struct for existing configurations in remote Alertmanagers. Related PR: grafana/mimir#8066This PR also uses the default global configuration for the Alertmanager if the current global config is
nil. This fixes panics when using upstream's codebase (see this pointer dereference).