-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develocity URL is enforced even if Develocity plugin is not applied by the init script #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
commented
Oct 22, 2024
erichaagdev
force-pushed
the
erichaagdev/always-enforce-url
branch
2 times, most recently
from
October 24, 2024 14:44
89a10f9
to
a3ad9d4
Compare
welandaz
approved these changes
Oct 25, 2024
erichaagdev
force-pushed
the
erichaagdev/always-enforce-url
branch
from
October 25, 2024 13:54
a3ad9d4
to
93a3c73
Compare
bigdaz
requested changes
Oct 31, 2024
erichaagdev
force-pushed
the
erichaagdev/always-enforce-url
branch
2 times, most recently
from
November 13, 2024 03:04
b756754
to
927e4ab
Compare
…as not applied by injection
erichaagdev
force-pushed
the
erichaagdev/always-enforce-url
branch
from
November 13, 2024 03:12
927e4ab
to
ee63ce9
Compare
erichaagdev
commented
Nov 13, 2024
bigdaz
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just left one comment that could trigger a minor improvement.
I've done enough testing with the Develocity Build Validation Scripts to verify these changes work, though I am running into other unrelated issues. Going to go ahead and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR widens the scope of Develocity URL enforcement by setting the Develocity server URL even if the Develocity plugin was not applied by the init script.
This supports the Develocity Build Validation Script
-s
use case.