Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develocity URL is enforced even if Develocity plugin is not applied by the init script #10

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

erichaagdev
Copy link
Member

This PR widens the scope of Develocity URL enforcement by setting the Develocity server URL even if the Develocity plugin was not applied by the init script.

This supports the Develocity Build Validation Script -s use case.

src/main/resources/develocity-injection.init.gradle Outdated Show resolved Hide resolved
src/main/resources/develocity-injection.init.gradle Outdated Show resolved Hide resolved
src/main/resources/develocity-injection.init.gradle Outdated Show resolved Hide resolved
src/main/resources/develocity-injection.init.gradle Outdated Show resolved Hide resolved
@erichaagdev erichaagdev force-pushed the erichaagdev/always-enforce-url branch 2 times, most recently from b756754 to 927e4ab Compare November 13, 2024 03:04
Copy link
Member

@bigdaz bigdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left one comment that could trigger a minor improvement.

src/test/groovy/com/gradle/TestDevelocityInjection.groovy Outdated Show resolved Hide resolved
@erichaagdev
Copy link
Member Author

I've done enough testing with the Develocity Build Validation Scripts to verify these changes work, though I am running into other unrelated issues. Going to go ahead and merge this one.

@erichaagdev erichaagdev merged commit 0566fe0 into main Nov 15, 2024
1 check passed
@erichaagdev erichaagdev deleted the erichaagdev/always-enforce-url branch November 15, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants