Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build scan link log parsing for multiple tasks #148

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

alextu
Copy link
Member

@alextu alextu commented Apr 24, 2024

The addForJob method was introduced in Bamboo 8.x API. So our plugin compatibility starts now at 8.x.

@alextu alextu added the bug Something isn't working label Apr 24, 2024
@alextu alextu self-assigned this Apr 24, 2024
@alextu alextu requested review from welandaz and guylabs April 24, 2024 07:18
Copy link
Member

@welandaz welandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed!

@@ -409,15 +409,15 @@
<id>bamboo924OrLater</id>
<properties>
<bamboo.product.data.path>
${basedir}/src/test/resources/generated-test-resources-923.zip
${basedir}/src/test/resources/generated-test-resources-9_2_13.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment such that we're not confused why we have different profiles (just mentioning a change in schema from 9.2.3 to 9.2.4)

@alextu alextu merged commit 565ee9f into main Apr 24, 2024
8 of 10 checks passed
@alextu alextu deleted the atual/fix-multiple-tasks branch April 24, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants