Add settings.gradle.dcl code assistance
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copy and reuse utilities from `gradle-client` for merging analysis results from multiple interpretation sequence steps. * Produce an approximate union schema for type lookup in `settings.gradle.dcl` where there is more than one schema from the multiple interpretation sequence steps. * Track the analysis schemas along with the documents in the language server state. * Use the schema's top-level receiver type for completion at the top-level when outside any matching element. * Simplify the `DeclarativeResourcesModel`, as the schemas and files are actually tracked by the DCL analysis utilities.
h0tk3y
force-pushed
the
sigushkin/settings-gradle-dcl
branch
from
ae3766b
to
38739e3
Compare
hegyibalint
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I see where you are going with this, and I'm happy for the model fetching simplification.
OTOH, I have this reservation against declarative, where... almost all of the code I'm seeing is considered magic, including the code added now. This is not a concern at the EAP stage, and I trust your code, but please keep this as a reminder that (at least I) have trouble understanding concepts below the surface of declarative gradle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.