Do not use the real document overlays for now #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text mutation utilities cannot handle the mutations touching the underlay document content. For now, use an empty "underlay" document, so that the overlay result of that stub and the real file is equivalent to the real file, which the mutation utilities can handle just fine.
hegyibalint
reviewed
Nov 13, 2024
Comment on lines
+312
to
+314
| // TODO: carry both the real overlay and the document produced from just the current file, run the mutations | ||
| // against the latter for now. | ||
| // TODO: once the mutation utilities start handling mutations across the overlay, pass them the right overlay. |
There was a problem hiding this comment.
🤔 Do you think issues would be useful for these, or are you going to come back here soon?
There was a problem hiding this comment.
I have some more changes in mind that are going to affect this.
hegyibalint
approved these changes
Nov 13, 2024
h0tk3y
merged commit 9487515
into
sigushkin/settings-gradle-kts-or-none
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.