Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README description for Gradle Build Server #26

Merged
merged 3 commits into from
May 8, 2024

Conversation

Sidhaarthsr
Copy link
Contributor

Extended description for the README.md file for Gradle Build Server in Buildship

Extended description for the README.md file for Gradle Build Server in Buildship
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

# GSoC 2024. Gradle Build Server - DevX and Language Support in Buildship

Description is coming soon
- **Project GitLab** - https://gitlab.eclipse.org/eclipsefdn/emo-team/gsoc-at-the-ef/-/issues/5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitlab Issue. I would recommend having another set of issues right inside the project repository and referencinh them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added placeholders for issues for implementation that will be created in the Eclipse Buildship and BSP Gradle repositories. Should I go ahead and create those tickets right away or create them during the coding phase while we start the implementation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, please can go ahead and create them. It is good for facilitating feedback from the community

* Execute tests
* Support additional languages

We will also implement the new fully-powered Gradle BSP for Eclipse Buildship
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would highlight this deliverable, because it looks bigger than the previous ones combined


## Architecture - BSP Gradle

![Architecture Image](https://raw.githubusercontent.com/Sidhaarthsr/gradle-bsp-resources/main/img/BSP_Gradle_Architecture.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend including it directly in the repository. Maybe we should do a project folder for that, I would use the same name as the markdown file. It would also allow moving the current file to the folder as README.md without breaking the site

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Normally I recommend commenting out placeholder links, but let's do it in a follow-up shortly

@oleg-nenashev oleg-nenashev merged commit 04b4df6 into gradle:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants