appended pageurl to datalayer (#9)

gradeup · Mar 22, 2023 · d7e5578 · d7e5578
1 parent fac49ab
commit d7e5578
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 74 deletions.
diff --git a/dist/helpers/append-gtm.js b/dist/helpers/append-gtm.js
@@ -41,7 +41,7 @@ var appendGtm = function appendGtm(_ref) {
 	if (nonce === '') {
 		noscript = '\n\t\t(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({\'gtm.start\': new Date().getTime(),event:\'gtm.js\', ' + eventsVar + ' });var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!=\'dataLayer\'?\'&l=\'+l:\'\';j.async=true;j.src= \'https://www.googletagmanager.com/gtm.js?id=\'+i+dl+\'' + authVar + previewVar + '\';f.parentNode.insertBefore(j,f); })(window,document, \'script\', \'' + dataLayerName + '\', \'' + id + '\');\n\t\t';
 	} else {
-		noscript = '\n\t\t(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({\'gtm.start\': new Date().getTime(),event:\'gtm.js\', ' + eventsVar + ' });var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!=\'dataLayer\'?\'&l=\'+l:\'\';j.async=true;j.nonce=' + nonce + ';j.src= \'https://www.googletagmanager.com/gtm.js?id=\'+i+dl+\'' + authVar + previewVar + '\';f.parentNode.insertBefore(j,f); })(window,document, \'script\', \'' + dataLayerName + '\', \'' + id + '\');\n\t\t';
+		noscript = '\n\t\t(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({\'gtm.start\': new Date().getTime(),event:\'gtm.js\', ' + eventsVar + ' });var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!=\'dataLayer\'?\'&l=\'+l:\'\';j.async=true;j.nonce=\'' + nonce + '\';j.src= \'https://www.googletagmanager.com/gtm.js?id=\'+i+dl+\'' + authVar + previewVar + '\';f.parentNode.insertBefore(j,f); })(window,document, \'script\', \'' + dataLayerName + '\', \'' + id + '\');\n\t\t';
 	}
 	(0, _appendToHtml2.default)({ data: noscript, head: true, reactFlag: reactFlag, nonce: nonce });
 	/* Google Tag Manager (script) : Goes in the head tag */

diff --git a/dist/index.js b/dist/index.js
@@ -44,6 +44,14 @@ var GTM = {
 		    reactFlag = _ref2.reactFlag,
 		    event = _ref2.event;
 
+		// pageurl: window.location.href on gtm, will create discrepency with
+		// pagename: datalayer.get('pageName')
+		// because href is calculated at the time and pagename is already present in datalayer
+		// appending pageurl to datalayer too,
+		// to sync pagename and pageurl
+		if (dataLayer && dataLayer.pageName) {
+			dataLayer.dlPageUrl = dataLayer.dlPageUrl || global.location.href;
+		}
 		(0, _dataLayer2.default)({ dataLayerName: dataLayerName, dataLayer: dataLayer, state: state, reactFlag: reactFlag, event: event });
 	},
 	fireEvent: _fireEvent2.default

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/index.js b/src/index.js
@@ -12,6 +12,14 @@ const GTM = {
 		dataLayerFn({id, dataLayerName, dataLayer, state: 0, reactFlag});
 	},
 	appendDL: ({ dataLayerName, dataLayer, state, reactFlag, event }) => {
+		// pageurl: window.location.href on gtm, will create discrepency with
+		// pagename: datalayer.get('pageName')
+		// because href is calculated at the time and pagename is already present in datalayer
+		// appending pageurl to datalayer too,
+		// to sync pagename and pageurl
+		if (dataLayer && dataLayer.pageName) {
+			dataLayer.dlPageUrl = dataLayer.dlPageUrl || global.location.href;
+		}
 		dataLayerFn({dataLayerName, dataLayer, state, reactFlag, event});
 	},
 	fireEvent