Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow multiple attempts #107

Merged
merged 18 commits into from
Jan 15, 2024
Merged

feat: allow multiple attempts #107

merged 18 commits into from
Jan 15, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Dec 28, 2023 •
edited
Loading

This PR includes:

  • The implementation of the multiple attempts feature.
  • The read only feature, blocking user to retry when max. attempts are reached.
  • Display the user's last answer.
  • Fix some bugs.

@ReidyT ReidyT added the feature New feature or request label Dec 28, 2023
@ReidyT ReidyT requested review from pyphilia and spaenleh December 28, 2023 13:22
@ReidyT ReidyT self-assigned this Dec 28, 2023
@ReidyT ReidyT linked an issue Dec 28, 2023 that may be closed by this pull request
Allow multiple attempts before showing response #19
Closed
This was referenced Dec 28, 2023
Merged
Closed
@ReidyT ReidyT linked an issue Dec 29, 2023 that may be closed by this pull request
CreateView seems to be rerender too many times #109
Closed
ReidyT added 16 commits January 5, 2024 10:22
@ReidyT
feat: first implementation for TextInput
740b201
@ReidyT
fix: set the PlayTextInput color correctly when disabled
dcb205b
@ReidyT
feat: get latest user's answer instead of first
7c37857
@ReidyT
test: implement E2E tests of play text with multiple attempts
f30dfa5
@ReidyT
test: write E2E tests for number of attempts in builder view
66a099e
@ReidyT
feat: update slider implementation to allow multiple attempts
540b5cc
@ReidyT
test: update play slider tests to use multiple attempts
cdcfdf0
@ReidyT
feat: update PlayFillInTheBlanks to allow multiple attempts
d792288
@ReidyT
test: update play fillBlanks test to test multiple attempts
c262a1f
@ReidyT
feat: implement multiple attempts for MultipleChoices
be182ce
@ReidyT
fix: update disabled colors
252a34f
@ReidyT
test: update multipleChoices test to include multiple attemtps
c8459e0
@ReidyT
feat: translate the number of attempts
ce6191c
@ReidyT
fix: update analytics and results for multiple attempts
b8edde5
@ReidyT
fix: remove useEffect in NumberOfAttempts to avoid infinite rerender
42fb6b9
@ReidyT
feat: do not display explanations of multiple choice until the end of…
ad5702a 
… the attempts
@ReidyT ReidyT force-pushed the 19-allow-multiple-attempts branch from 5ce14f6 to ad5702a Compare January 5, 2024 09:23
spaenleh
spaenleh requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Please see my comments and request a new review once they are fixed ! Good work ! 🏙️

cypress/e2e/Admin/create/numberOfAttempts.cy.ts Show resolved Hide resolved
cypress/e2e/Admin/create/numberOfAttempts.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/play/fillBlanks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/play/textInput.cy.ts Outdated Show resolved Hide resolved
cypress/fixtures/appSettings.ts Outdated Show resolved Hide resolved
src/components/context/utilities.ts Outdated Show resolved Hide resolved
src/components/context/utilities.ts Outdated Show resolved Hide resolved
src/components/play/PlayView.tsx Outdated Show resolved Hide resolved
src/components/play/PlayView.tsx Outdated Show resolved Hide resolved
src/components/results/TableByUser.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from spaenleh January 9, 2024 16:14
@ReidyT ReidyT force-pushed the 19-allow-multiple-attempts branch from 6a34b1a to cefd255 Compare January 10, 2024 07:39
@ReidyT ReidyT force-pushed the 19-allow-multiple-attempts branch from cefd255 to cf269af Compare January 10, 2024 07:40
spaenleh
spaenleh approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final changes and you can merge

src/components/context/utilities.ts Outdated Show resolved Hide resolved
src/config/selectors.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT merged commit 526da9b into main Jan 15, 2024
3 checks passed
@ReidyT ReidyT deleted the 19-allow-multiple-attempts branch January 15, 2024 09:24
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Merged
spaenleh pushed a commit that referenced this pull request Jan 17, 2024
@ReidyT @spaenleh
feat: allow multiple attempts (#107)
57bd30c 
* feat: first implementation for TextInput

* fix: set the PlayTextInput color correctly when disabled

* feat: get latest user's answer instead of first

* test: implement E2E tests of play text with multiple attempts

* test: write E2E tests for number of attempts in builder view

* feat: update slider implementation to allow multiple attempts

* test: update play slider tests to use multiple attempts

* feat: update PlayFillInTheBlanks to allow multiple attempts

* test: update play fillBlanks test to test multiple attempts

* feat: implement multiple attempts for MultipleChoices

* fix: update disabled colors

* test: update multipleChoices test to include multiple attemtps

* feat: translate the number of attempts

* fix: update analytics and results for multiple attempts

* fix: remove useEffect in NumberOfAttempts to avoid infinite rerender

* feat: do not display explanations of multiple choice until the end of the attempts

* chore: improve code from code review

* chore: last improvements in the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@ReidyT ReidyT

Labels
feature New feature or request v1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateView seems to be rerender too many times Allow multiple attempts before showing response
2 participants
@ReidyT @spaenleh