Refactoring try-excepts and remove prints. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9r5
reviewed
Dec 16, 2024
| f"Leaderboard '{leaderboard_name}' created.\n" | ||
| + f"Reference code: {reference_code}.\n" | ||
| + f"Submission deadline: {date_value}", | ||
| print("HAHA", err) |
There was a problem hiding this comment.
Suggested change
| print("HAHA", err) |
b9r5
reviewed
Dec 16, 2024
| logger.error(str(e)) | ||
| if "'NoneType' object is not subscriptable" in str(e): | ||
| await interaction.response.send_message( | ||
| f"The leaderboard '{leaderboard_name}' doesn't exist.", |
There was a problem hiding this comment.
This would be weird because there was already a db.get_leaderboard(...) call above.
b9r5
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the try-except logic in the leaderboard cog. It also removes redundant prints, and prevents leaking exact error traces to the Discord user. It also fixes a bug for when a duplicate leaderboard is created, and returns a better user message.
Checklist
Before submitting this PR, ensure the following steps have been completed:
/verifyrunson your own server./verifyruns.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.