fixes for a couple of things in leaderboard cog #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
siro requested a change in leaderboard_cog.py where to use
interaction.response.send_message
for initial validations and thereafter useinteraction.followup.send
.I noticed a problem where the submission content was not being decoded. As a result, we get rows in the submission table like this (note the binary-looking data in the
code
column):After this change, we get rows in the submission table like this (note that the code column is legible after the change):
A couple of screenshots of tests:
Checklist
Before submitting this PR, ensure the following steps have been completed:
I manually verified that
/run modal
works, and that/run github
works for Nvidia.For some reason, I am not able to execute
/run github
for AMD at the moment./verifyruns
on your own server./verifyruns
.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.