Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix: Try to send interupt to sys.daemon to allow cleanup" #611

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Revert "Fix: Try to send interupt to sys.daemon to allow cleanup" #611

merged 1 commit into from
Jul 4, 2024

Conversation

StrongMonkey
Copy link
Contributor

@StrongMonkey StrongMonkey commented Jul 3, 2024 •
edited
Loading

This reverts commit 1104843.

Causing issue in other LLM provider, reverting.

njhale
njhale approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that, at minimum, the regression affects both the claude and mistral providers. I suspect it will cause problems for the other providers as well.

I've also verified that this revert fixes the problem for both providers.

@njhale njhale merged commit 89c29a5 into gptscript-ai:main Jul 4, 2024
10 checks passed
@njhale njhale mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@drpebcak drpebcak drpebcak approved these changes

@thedadams thedadams Awaiting requested review from thedadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrongMonkey @drpebcak @njhale