fix: normalize LLM-hallucinated tool names (#656)

Signed-off-by: Grant Linville <[email protected]>
gptscript-ai · Jul 23, 2024 · d54d11b · d54d11b
1 parent e3a43cb
commit d54d11b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/pkg/engine/engine.go b/pkg/engine/engine.go
@@ -396,7 +396,7 @@ func (e *Engine) complete(ctx context.Context, state *State) (*Return, error) {
 			}
 			if toolID == "" {
 				log.Debugf("failed to find tool id for tool %s in tool_call result", content.ToolCall.Function.Name)
-				toolID = content.ToolCall.Function.Name
+				toolID = types.ToolNormalizer(content.ToolCall.Function.Name)
 				missing = true
 			}
 			state.Pending[content.ToolCall.ID] = *content.ToolCall

diff --git a/pkg/tests/runner_test.go b/pkg/tests/runner_test.go
@@ -954,7 +954,7 @@ func TestMissingTool(t *testing.T) {
 
 	r.RespondWith(tester.Result{
 		Func: types.CompletionFunctionCall{
-			Name: "not bob",
+			Name: "not.bob",
 		},
 	})
 

diff --git a/pkg/tests/testdata/TestMissingTool/call1-resp.golden b/pkg/tests/testdata/TestMissingTool/call1-resp.golden
@@ -5,7 +5,7 @@
       "toolCall": {
         "id": "call_1",
         "function": {
-          "name": "not bob"
+          "name": "not.bob"
         }
       }
     }

diff --git a/pkg/tests/testdata/TestMissingTool/call2.golden b/pkg/tests/testdata/TestMissingTool/call2.golden
@@ -35,7 +35,7 @@
           "toolCall": {
             "id": "call_1",
             "function": {
-              "name": "not bob"
+              "name": "not.bob"
             }
           }
         }
@@ -46,13 +46,13 @@
       "role": "tool",
       "content": [
         {
-          "text": "ERROR: can not call unknown tool named [not bob]"
+          "text": "ERROR: can not call unknown tool named [notBob]"
         }
       ],
       "toolCall": {
         "id": "call_1",
         "function": {
-          "name": "not bob"
+          "name": "not.bob"
         }
       },
       "usage": {}