This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Remove newline(s) from written files #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azerella
force-pushed
the
develop
branch
2 times, most recently
from
78d43e2
to
f7e15ef
Compare
| * To compare file data hashes across platforms, we | ||
| * need to remove \n or \r\n newlines | ||
| */ | ||
| content = content.replace( /[\r\n]/gm, '' ); |
There was a problem hiding this comment.
Can we keep the new line and get tests to pass for both platforms? Or perhaps force the same new line across platforms
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.3.4 to 7.4.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.3.4...v7.4.2) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/core](https://github.com/babel/babel) from 7.3.4 to 7.4.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.3.4...v7.4.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [uglify-js](https://github.com/mishoo/UglifyJS2) from 3.4.9 to 3.5.2. - [Release notes](https://github.com/mishoo/UglifyJS2/releases) - [Commits](mishoo/UglifyJS@v3.4.9...v3.5.2) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [uglify-js](https://github.com/mishoo/UglifyJS2) from 3.5.2 to 3.5.3. - [Release notes](https://github.com/mishoo/UglifyJS2/releases) - [Commits](mishoo/UglifyJS@v3.5.2...v3.5.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [del](https://github.com/sindresorhus/del) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/sindresorhus/del/releases) - [Commits](sindresorhus/del@v4.0.0...v4.1.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.4.2 to 7.4.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.4.2...v7.4.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/cli](https://github.com/babel/babel) from 7.2.3 to 7.4.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.2.3...v7.4.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.4.10 to 9.5.1. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](postcss/autoprefixer@9.4.10...9.5.1) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/core](https://github.com/babel/babel) from 7.4.0 to 7.4.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.4.0...v7.4.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jest-cli](https://github.com/facebook/jest/tree/HEAD/packages/jest-cli) from 24.5.0 to 24.7.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v24.7.1/packages/jest-cli) Signed-off-by: dependabot[bot] <[email protected]>
azerella
force-pushed
the
master
branch
3 times, most recently
from
34abc27
to
76833d5
Compare
|
Although important to address, I'm moving this issue to the icebox - This type of issue is apart of a bigger problem that we need to look at later on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #113
When the
pancakemodule writes files using theWriteFile()function, it does so with a newline. This causes problems with our test suite as we need to compare file content hashes. Unix and Windows handle newlines differently and this results in mismatching hashes for Windows, ergo the tests fail..babelrcfrom rootpancakemodule.09/04/19