Fix some dialyzer warnings #712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time field in the txq record can actually be undefined (for example when the rx2_rf exported function is called), so update the typespec to enable the time to be undefined.
gotthardp
requested changes
Mar 16, 2020
src/lorawan_utils.erl
Outdated
| @@ -159,7 +159,6 @@ event_args(Event) when is_atom(Event) -> | |||
| event_args(Event) when is_binary(Event) -> | |||
| {Event, undefined}. | |||
|
|
|||
| inc(undefined) -> 1; | |||
There was a problem hiding this comment.
This has a reason. The dialyzer is wrong when saying this will never be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two sets of dialyzer warnings:
txqrecord can actually be undefined (for example when therx2_rfexported function is called), so update the typespec to let thetimeto beundefined.inc(undefined)clause inlorawan_utilstheNumparameter could never beundefined(unless after a database upgrade?).Generally, are you interested in similar dialyzer-related cleanups?