Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests so that they run properly #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lukaso
Copy link

@lukaso lukaso commented Oct 17, 2014

However, the result is not a working app. The main thing here is I got the tests running and got rid of warnings. I did this all on Ruby 2.1.3

I had to comment one test out because it couldn't figure out how to build 'pkg' but then when I go to build again, I have to rm -rf pkg anyway to get the app to build again.

Hope this helps (and sorry I forgot about the topic branch). Started committing on master before I thought it through.

@@ -275,7 +275,7 @@
[ :Task, "build:windows", %w[build:windows:installer] ],
[ :Task, "build:windows:installer", ["#{folder_base}_WIN32_INSTALLER"] ],

[ :FileTask, 'pkg', [] ],
# [ :FileTask, 'pkg', [] ],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test I commented out, because I couldn't figure out what it was doing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember what it was doing...

@bil-bas
Copy link
Collaborator

bil-bas commented Oct 22, 2014

Mmm.

As I pointed out, the exclusion of bundler is correct.

Well, one problem is that the OSX wrappers are only for Ruby 1.9.2, so no gems compiled for 2.x (or 1.8.x for that matter) would work on that platform.

@lukaso
Copy link
Author

lukaso commented Oct 23, 2014

I think the gosu osx wrappers might be for ruby 2 now, but I'm not sure. I haven't gotten it working so can't really vouch. Here's a ruby 2.1.2 wrapper: https://github.com/jlnr/ruby_app/releases/tag/v0.7.50

From the comments:
• Ruby 2.1.2p95
• Gosu 0.7.50
• OpenGL 0.8.0 (or 0.9.0; not sure)
• Chipmunk 6.1.3.1
• Ashton 0.1.3
• Texplay 0.4.4 (the binary for PowerPC is missing, contact me if this is an issue)
• Requires 10.8 for 64-bit Intel, 10.6 for 32-bit Intel, 10.5 for 32-bit PowerPC

@jlnr jlnr self-assigned this Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants