-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tests so that they run properly #55
base: master
Are you sure you want to change the base?
Conversation
packaging problems as can't find it's directory.
@@ -275,7 +275,7 @@ | |||
[ :Task, "build:windows", %w[build:windows:installer] ], | |||
[ :Task, "build:windows:installer", ["#{folder_base}_WIN32_INSTALLER"] ], | |||
|
|||
[ :FileTask, 'pkg', [] ], | |||
# [ :FileTask, 'pkg', [] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test I commented out, because I couldn't figure out what it was doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember what it was doing...
Mmm. As I pointed out, the exclusion of bundler is correct. Well, one problem is that the OSX wrappers are only for Ruby 1.9.2, so no gems compiled for 2.x (or 1.8.x for that matter) would work on that platform. |
I think the gosu osx wrappers might be for ruby 2 now, but I'm not sure. I haven't gotten it working so can't really vouch. Here's a ruby 2.1.2 wrapper: https://github.com/jlnr/ruby_app/releases/tag/v0.7.50 From the comments: |
However, the result is not a working app. The main thing here is I got the tests running and got rid of warnings. I did this all on Ruby 2.1.3
I had to comment one test out because it couldn't figure out how to build 'pkg' but then when I go to build again, I have to
rm -rf pkg
anyway to get the app to build again.Hope this helps (and sorry I forgot about the topic branch). Started committing on master before I thought it through.