feat(track,core): support clockwise orientation in circular track #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etowahadams
commented
Jun 11, 2024
Comment on lines
+7
to
+17
| export function valueToRadian(v: number, max: number, sa: number, ea: number, clockwise?: boolean) { | ||
| const safeVal = Math.max(Math.min(max, v), 0); | ||
| const gap = g ?? RADIAN_GAP; | ||
| const gap = RADIAN_GAP; | ||
| const radExtent = ((ea - sa) / 360) * Math.PI * 2 - gap * 2; | ||
| const radStart = (sa / 360) * Math.PI * 2; | ||
| return -(radStart + (safeVal / max) * radExtent) - Math.PI / 2.0 - gap; | ||
| const result = -(radStart + (safeVal / max) * radExtent) - Math.PI / 2.0 - gap; | ||
|
|
||
| if (clockwise) { | ||
| return -result - Math.PI; | ||
| } | ||
| return result; |
There was a problem hiding this comment.
The main strategy is to add a "clockwise" option to to the radian calculation
etowahadams
commented
Jun 11, 2024
| @@ -4,21 +4,35 @@ export const RADIAN_GAP = 0; //0.04; | |||
| * Convert a value in a single-linear axis to a radian value. Anticlockwise, starts from 12 o'clock. | |||
| * v span from zero to `max`. | |||
| */ | |||
| export function valueToRadian(v: number, max: number, sa: number, ea: number, g?: number) { | |||
There was a problem hiding this comment.
g?: number option was not used anywhere so got rid of it
|
TODO: fix the clockwise brush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #280
Toward #
Change List
clockwiseoption to circular tracks to change the orientation.Makes changes to axis, brush, and marks
Clockwise:
Not clockwise:
Example of clockwise axis
Checklist