-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(track): Persist GoslingTrackModels #1044
Conversation
Persisting GoslingTrackModels is something I originally tested in #1039. This offers substantial performance improvements since now the GoslingTrackModels don't have to be regenerated with every draw() call. It does seem that |
// If we have already processed all tiles, we don't need to do anything | ||
// this.#processedTileMap contains all of data needed to draw | ||
if (tiles.every(tile => this.#processedTileMap.get(tile) !== undefined)) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! I assume this also increases the performance to some extent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot for such a quick fix!
|
Fix #1043
Toward #
Change List
structuredClone()
toJSON.parse(JSON.stringify())
Screen.Recording.2024-02-22.at.9.47.14.AM.mov
Checklist