Skip to content

Commit

Permalink
add Adrian as codeowner so it can be him or core-enablement team to a…
Browse files Browse the repository at this point in the history
…pprove PRs and updates to testing
  • Loading branch information
rkeur7 committed Nov 18, 2024
1 parent 5f88a6d commit cf6cbc5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 20 deletions.
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* @goshippo/core-enablement
* @goshippo/core-enablement
* @AdrianCollinsShippo
24 changes: 5 additions & 19 deletions .github/workflows/sdk_validation.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: Validate

permissions:
contents: write
id-token: write
Expand All @@ -17,31 +18,16 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
concurrency:
group: php-sdk-check
group: php-sdk-check-${{ github.event.pull_request.number }}
steps:
- name: Authenticate with AWS
uses: goshippo/shippo-action-workflows/.github/actions/[email protected]
with:
environment: dev-main
oidc-name: shippo-php-sdk-pipeline
login-to-ecr: false

- name: Get Speakeasy Secrets Manager
uses: aws-actions/aws-secretsmanager-get-secrets@v2
with:
secret-ids: |
dev-main-speakeasy-api-key
name-transformation: uppercase
parse-json-secrets: true

- name: Check out repository
uses: actions/checkout@v4

- name: Set up PHP
id: setup_php
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'
php-version: '8.2'

- name: cache dependencies
uses: actions/cache@v4
Expand All @@ -54,6 +40,6 @@ jobs:
make install
- name: Check
run: make check
run: make check
env:
SHIPPO_TOKEN: ${{ env.DEV_MAIN_SPEAKEASY_API_KEY_SHIPPO_TOKEN }}
SHIPPO_TOKEN: ${{ secrets.SHIPPO_TOKEN }}

0 comments on commit cf6cbc5

Please sign in to comment.