Skip to content

Commit

Permalink
Change Code Owners So Core Enablement can start reviewing the changes (
Browse files Browse the repository at this point in the history
…#86)

* add codeowner for entire codebase to core-enablement

* update makefile

* update paths for imports in tests
  • Loading branch information
rkeur7 authored Oct 29, 2024
1 parent a4dd0e2 commit 408c269
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 8 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @goshippo/core-enablement
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
LOCAL_SPEC_FILE=./build/public-api.yaml
BUILD_DIR=./build/
LOCAL_SPEC_FILE=${BUILD_DIR}public-api.yaml

install:
npm install
Expand All @@ -19,7 +20,8 @@ speakeasy-install: # dev task, locally install the speakeasy CLI
speakeasy auth login

download-public-spec: # dev task, download the current public spec, in preparation for modifying and running speakeasy-generate
curl https://docs.goshippo.com/spec/shippoapi/public-api.yaml > $$LOCAL_SPEC_FILE
mkdir -p ${BUILD_DIR}
curl https://docs.goshippo.com/spec/shippoapi/public-api.yaml > ${LOCAL_SPEC_FILE}

speakeasy-generate: # dev task, run the generator on a local spec. useful for testing out changes to the spec or gen.yaml - but DO NOT commit the results of manual generation
if [ ! -f "${LOCAL_SPEC_FILE}" ]; then \
Expand Down
4 changes: 2 additions & 2 deletions test/helpers.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {CarrierAccountWithExtraInfo, CarriersEnum} from "../models/components";
import {Shippo} from "../sdk";
import {CarrierAccountWithExtraInfo, CarriersEnum} from "../src/models/components";
import {Shippo} from "../src/sdk";

export const shippoSdk = new Shippo({
apiKeyHeader: process.env.SHIPPO_TOKEN
Expand Down
2 changes: 1 addition & 1 deletion test/instalabel.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {expect} from 'chai';
import {describe, it} from 'mocha';
import {CarriersEnum, DistanceUnitEnum, WeightUnitEnum} from '../models/components';
import {CarriersEnum, DistanceUnitEnum, WeightUnitEnum} from '../src/models/components';
import {shippoSdk, getCarrierAccount} from "./helpers";

describe('TestInstalabel', function() {
Expand Down
2 changes: 1 addition & 1 deletion test/purchaseLabel.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {describe, it} from 'mocha';
import {expect} from "chai";
import {CarriersEnum, DistanceUnitEnum, WeightUnitEnum} from '../models/components';
import {CarriersEnum, DistanceUnitEnum, WeightUnitEnum} from '../src/models/components';
import {getCarrierAccounts, shippoSdk} from "./helpers";


Expand Down
2 changes: 1 addition & 1 deletion test/purchaseLabelInternational.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
CustomsDeclarationNonDeliveryOptionEnum,
DistanceUnitEnum,
WeightUnitEnum
} from '../models/components';
} from '../src/models/components';
import {shippoSdk} from "./helpers";


Expand Down
2 changes: 1 addition & 1 deletion test/ratesAtCheckout.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
ServiceLevelUPSEnum,
DistanceUnitEnum,
WeightUnitEnum,
} from '../models/components';
} from '../src/models/components';
import {expect} from "chai";
import {getCarrierAccount, shippoSdk} from "./helpers";

Expand Down

0 comments on commit 408c269

Please sign in to comment.