REFACTOR update detectors for Embed 4.x #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a fork with recent support for embed/embed:^4 at https://github.com/dnadesign/silverstripe-embed - maybe the module is going to be maintained there? As it's a change from embed 3 to 4, it would be a good to land this change as v2 and then release a patch for v1 to restrict embed/embed to ^3. |
|
thanks @JamesDPC ! Hard to tell which version will be supported moving forward, but the DNA fork has been updated recently, I'll give it a shot in our project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the detectors to be compatible with embed/embed 4.x releases.
The
typedetector was removed from embed, so for now I've manually set$owner->EmbedType = 'video';to be as non-disruptive to the template logic.Subsequently, I've also commented out the
validate()function as it's really only checking forEmbedType. I'm happy to adjust this if desired.Like we did with Linkable, we're looking to migrate our oEmbed (Media) block away from Linkable and to your Embed module. If there's anything else we can help with we're happy to do so!