feat: [#449] Implement HTTP response stream #77
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
kkumar-gcc
changed the title
context_response.go
Outdated
| @@ -89,6 +89,10 @@ func (r *ContextResponse) Status(code int) contractshttp.ResponseStatus { | |||
| return NewStatus(r.instance, code) | |||
| } | |||
|
|
|||
| func (r *ContextResponse) Stream(step func(w contractshttp.StreamWriter) error, code int, contentType string) contractshttp.Response { | |||
There was a problem hiding this comment.
Do we need to set contentType for stream? If the contentType is only used by SSE, can we add another SSEvent method to deal with it?
There was a problem hiding this comment.
It is not necessary; we can remove contentType. We don't need the SSEvent method since we provide the Header method, allowing the user to set it directly if needed.
ctx.Response().Header("Content-Type", "text/event-stream").Stream(...)
context_response_test.go
Outdated
| return r.closeChannel | ||
| } | ||
|
|
||
| func (r *TestResponseRecorder) closeClient() { |
There was a problem hiding this comment.
Where? I don't find the case.
response.go
Outdated
|
|
||
| w := NewStreamWriter(r.instance) | ||
|
|
||
| clientGone := r.instance.Writer.CloseNotify() |
There was a problem hiding this comment.
I noticed the method is deprecated.
We should use:
ctx := r.instance.Request.Context()
...
case <-ctx.Done():
There was a problem hiding this comment.
Ohh, you are right, missed it.
context_response_test.go
Outdated
| type TestResponseRecorder struct { | ||
| *httptest.ResponseRecorder | ||
| closeChannel chan bool | ||
| } | ||
|
|
||
| func CreateTestResponseRecorder() *TestResponseRecorder { | ||
| return &TestResponseRecorder{ | ||
| httptest.NewRecorder(), | ||
| make(chan bool, 1), | ||
| } | ||
| } | ||
|
|
||
| func (r *TestResponseRecorder) CloseNotify() <-chan bool { | ||
| return r.closeChannel | ||
| } |
📑 Description
Closes goravel/goravel#449
@coderabbitai summary
✅ Checks