-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [#539] Remove the SQL migrator module #809
Conversation
WalkthroughThis pull request involves the removal of the SQL migrator module and several associated files within the database migration system. Key changes include the deletion of the SQLite driver, SQL-related migration files, and the refactoring of core migration-related structs and methods, such as renaming Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
💤 Files with no reviewable changes (5)
🚧 Files skipped from review as they are similar to previous changes (5)
🧰 Additional context used🪛 GitHub Check: codecov/patchdatabase/service_provider.go[warning] 84-84: database/service_provider.go#L84 ⏰ Context from checks skipped due to timeout of 300000ms (2)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
==========================================
- Coverage 69.78% 69.57% -0.22%
==========================================
Files 218 215 -3
Lines 18876 18499 -377
==========================================
- Hits 13172 12870 -302
+ Misses 4988 4962 -26
+ Partials 716 667 -49 ☔ View full report in Codecov by Sentry. |
📑 Description
Closes goravel/goravel#539
Summary by CodeRabbit
Release Notes
Refactoring
DefaultMigrator
toMigrator
Dependency Changes
Code Cleanup
Error Handling
These changes represent a significant refactoring of the database migration system, focusing on simplifying the implementation and reducing complexity.
✅ Checks