Issue #678: Fix Variant to handle nil slices #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix isn't entirely correct and the tests are too complex. Working on it. |
magiconair
changed the title
Fix the Variant encoder and decoder to handle nil slices correctly by setting the length to -1. Closes #678
magiconair
force-pushed
the
issue-678
branch
from
199ccf6 to
3c34d35
Compare
|
@kung-foo could you have a look? Then I can merge this as well and release v0.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Variant encoder and decoder to handle nil slices
correctly by setting the length to -1.
https://reference.opcfoundation.org/Core/Part6/v104/docs/5.2.5
Closes #678