notify when there are no notifications on a publication response #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is no feedback from a call to the server asking for the latest changes in a subscription where the request is successful but there where no messages.
The change in this PR allows a client to know that the connection is still good but that there are no changed values. This is allows it to differentiate from the situation where there are no notifications being sent due to a bad slow connection.
I am not 100% sure this should be an error but I felt like it was a similar case to the "empty NotificationMessage" notification that is sent a few lines above in the case that the notif message itself is nil.