Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unnecessary rerendering of clusters when nothing has changed #802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent unnecessary rerendering of clusters when nothing has changed #802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e61286
Prevent unnecessary rerendering of not changed clusters
ixam1 Nov 16, 2023
155a732
fix: prevent unnecessary rerendering
ixam1 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/markerclusterer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ export class MarkerClusterer extends OverlayViewSafe {
});

// Allow algorithms to return flag on whether the clusters/markers have changed.
if (changed || changed == undefined) {
// But if the cluster amount hasnt changed dont rerender unnecessarily, since nothing has changed
if (clusters.length !== this.clusters.length && (changed || changed == undefined)) {
// Accumulate the markers of the clusters composed of a single marker.
// Those clusters directly use the marker.
// Clusters with more than one markers use a group marker generated by a renderer.
Expand Down Expand Up @@ -208,7 +209,7 @@ export class MarkerClusterer extends OverlayViewSafe {
groupMarkers.push(cluster.marker);
}
}

this.clusters = clusters;
this.renderClusters();

Expand Down
Loading