Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up new snippets modules for region tags #1368

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Conversation

wangela
Copy link
Contributor

@wangela wangela commented Oct 28, 2023

Consolidate region tags for devsite snippets to /snippets folder

@snippet-bot
Copy link

snippet-bot bot commented Oct 28, 2023

Here is the summary of possible violations 😱

There are 70 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 85 region tags.
You are about to delete 80 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@wangela wangela requested a review from jonesfloyd October 30, 2023 23:42
@wangela wangela merged commit f777167 into main Oct 31, 2023
9 of 10 checks passed
@wangela wangela deleted the wangela/snippets branch October 31, 2023 16:33
kikoso pushed a commit that referenced this pull request Aug 14, 2024
* chore: move MapsCompose.kt to snippets/app-compose app

* chore: create app-places-ktx snippets module with places-ktx install snippet

* chore: create app-maps-rx snippets module

* chore: create app-ktx snippets module

* chore: add app-utils-ktx snippets module

* chore: rename app-maps-rx to app-rx

* chore: add app-utils snippets module

* chore: move region tag from tutorials to snippets for play services sdk dependency

* chore: move kotlin utils to app-utils-ktx module

* chore: move utils and utils-ktx snippets into corresponding modules

* chore: finalize maps sdk snippets

* chore: upgrade AGP and add namespaces

* chore: fix build issues

* chore: udpate build workflow to Java 17

* chore: fix build errors

* chore: remove v3 files

* Revert "chore: remove v3 files"

This reverts commit f70c47b.

* chore: add default PLACES_API_KEY to Current Place tutorial

* chore: fix tutorial builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant