Correct CI check for examples and add a unit test #4045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug within the CI check for unversioned changes to examples, involving an exclude pattern not matching relevant file paths that contain separators.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
My previous PR #3940 - which was merged and is now live - is causing CI pipelines to fail when any changes are made to YAML files in an example, even though these were supposed to have been excluded by a deny list.
This PR provides:
filepath.Match()
call on the filename (fromfilepath.Split()
) and not the full path.Which issue(s) this PR fixes:
Closes #4042
Special notes for your reviewer:
I am very sorry about this, and hope this hasn't left a bad impression.