Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CI check for examples and add a unit test #4045

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

wheatear-dev
Copy link
Contributor

This fixes a bug within the CI check for unversioned changes to examples, involving an exclude pattern not matching relevant file paths that contain separators.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

My previous PR #3940 - which was merged and is now live - is causing CI pipelines to fail when any changes are made to YAML files in an example, even though these were supposed to have been excluded by a deny list.

This PR provides:

  1. A unit test that reproduces the bug (on previous code)
  2. A small code fix, that operates the filepath.Match() call on the filename (from filepath.Split()) and not the full path.

Which issue(s) this PR fixes:

Closes #4042

Special notes for your reviewer:

I am very sorry about this, and hope this hasn't left a bad impression.

This fixes a bug within the CI check for unversioned changes to examples, involving an exclude pattern not matching relevant file paths that contain separators.
@github-actions github-actions bot added kind/bug These are bugs. size/S labels Nov 21, 2024
@gongmax
Copy link
Collaborator

gongmax commented Nov 21, 2024

/gcbrun

@gongmax
Copy link
Collaborator

gongmax commented Nov 21, 2024

Thank you for the quick fix! I didn't notice the case when reviewing the code so it's on me too :)

@gongmax gongmax enabled auto-merge (squash) November 21, 2024 18:06
@gongmax
Copy link
Collaborator

gongmax commented Nov 21, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: d8e6c6d8-6693-4772-9f4e-20ffd3b18d7c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4045/head:pr_4045 && git checkout pr_4045
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-74bde9b

@gongmax gongmax merged commit ae07c81 into googleforgames:main Nov 21, 2024
4 checks passed
@wheatear-dev wheatear-dev deleted the fix-ci-example branch November 22, 2024 13:02
0xaravindh pushed a commit to 0xaravindh/agones that referenced this pull request Nov 26, 2024
This fixes a bug within the CI check for unversioned changes to examples, involving an exclude pattern not matching relevant file paths that contain separators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI check check-example-versions doesn't work as expected.
3 participants