Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates upgrades tests into Cloud Build #4037

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Integrates upgrades tests into Cloud Build #4037

wants to merge 9 commits into from

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 18, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

This PR integrates the in place upgrades tests into the Cloud Build CI / CD pipeline. Once these tests are in place they will run in parallel with the e2e tests for each build.

  • Builds, pushes, and applies the necessary .yaml files to the upgrade test clusters for running the in place upgrades tests as part of the CI / CD testing suite.
  • Includes evictable "balloon" pods in the autopilot clusters that will maintain a buffer of available node space at all times. This will prevent the tests from failing on autopilot clusters due to scaling up and the quick churn of the test pods.
  • Updates the test container to watch game servers and pod events rather than pods. This covers more edge failure cases (such as ImagePullBackOff) than previously.
  • Adds a few more permissions that were causing logged errors with using Helm to delete Agones resources as part of the test cleanup.
  • Makes a few updates to versions to remove old cluster versions that are no longer in use from the version map, and adds new cluster versions.

Which issue(s) this PR fixes:

Working on #3795

Special notes for your reviewer:

While writing this PR I discovered that when the test container exists correctly (sdk.shutdown is called and the container exits with status 0), the pod attached to the game server exits with status 2. This will require more investigation as to why the pod reports a non-zero exit code when the side car and main container were shut down correctly.

@github-actions github-actions bot added kind/feature New features for Agones size/L labels Nov 18, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a87125df-ffe9-4923-b8a1-64d777648220

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 78bead89-d9f0-49ee-8584-48d67165b2f9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4037/head:pr_4037 && git checkout pr_4037
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-864e332

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 824ef53b-7110-4070-9c13-f011d59add5c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: d9982ce5-87ee-4bf0-8329-3b39eeb74ef7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 93b2a488-08c0-492a-8c0b-3ed45fae46b5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 33282874-f60f-4520-ac96-33ae555bfa21

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a3514a3a-08e8-4940-bafe-1795133abc3b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 70c6a664-728c-482c-b9dc-a3bbc46dc52c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 46ebd711-db56-4f46-bdf0-46fa65c16381

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 979dd3fe-2774-4b89-b7ab-3c550b933070

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 90781c0c-1ede-4cc0-85e2-24b09dc2acc0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 88d19424-f9de-4619-92cd-589ef8097f94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4037/head:pr_4037 && git checkout pr_4037
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-2e4f2ec

@igooch igooch force-pushed the testInPlaceUpgrades branch 2 times, most recently from f834aa9 to 9f64d99 Compare November 20, 2024 18:45
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: c9ca05de-9173-4084-81a3-6b96f3fc671a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0604a19d-e93c-4aeb-bff4-fac3fc6d4992

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c3fa65df-9c7b-442b-a673-9fa49a52540b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4037/head:pr_4037 && git checkout pr_4037
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-7168dd3

@igooch igooch marked this pull request as ready for review November 20, 2024 22:22
@igooch igooch requested a review from gongmax November 20, 2024 22:22
@igooch igooch force-pushed the testInPlaceUpgrades branch 2 times, most recently from bde5234 to 830fb7b Compare November 25, 2024 17:44
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6bc93c09-fe0b-4740-887b-fe240269c135

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 9c4f5638-ea39-4e33-b92e-cbfe3354627b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 438a762a-4598-40c7-bfbf-0c8f260bf103

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 474c1c46-c66c-4d42-a072-309645ff426c

Status: TIMEOUT

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 13c82489-7c63-4a43-a64e-5610a3938673

Status: TIMEOUT

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the testInPlaceUpgrades branch 2 times, most recently from 2eba81b to abe153b Compare November 26, 2024 17:37
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2b82082d-f704-4bd5-bd9a-b15084c3b6ea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4037/head:pr_4037 && git checkout pr_4037
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-abe153b

@igooch igooch force-pushed the testInPlaceUpgrades branch 2 times, most recently from a66cc44 to 971aa82 Compare November 26, 2024 22:46
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f063a6e1-8da8-446a-aee6-4e7f8cc20b7a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a500691b-e080-48e2-a16c-5c11019bb209

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 00a863ef-291d-49b4-a63a-7ede70293bb4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4037/head:pr_4037 && git checkout pr_4037
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-280ccb9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax Awaiting requested review from gongmax

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/feature New features for Agones size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igooch @agones-bot