Adding Fleet Active GameServerSet Percentage Metrics #4021

0xaravindh · 2024-10-23T14:40:53Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes: #3663

Closes #3663

Special notes for your reviewer:

agones-bot · 2024-10-23T14:46:57Z

Build Failed 😭

Build Id: cfa78591-f21a-4ef7-b788-64edd441876f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-10-23T16:50:18Z

Build Succeeded 🥳

Build Id: a4f0265c-59e0-41a5-a4cd-ab29381d9b0c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-000872c
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-000872c
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-000872c-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-000872c
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-000872c
Linux C++ SDK (build): agonessdk-1.45.0-dev-000872c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-000872c.zip

A preview of the website (the last 30 builds are retained):

https://000872c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-000872c

peterzhongyi · 2024-10-23T20:48:09Z

How should I verify that the newly added metric is working as intended? Is there some test that covers it, or can I perform some series of actions to verify the metric is working in the dashboard? If so, can you add to the description of the pr?

0xaravindh · 2024-10-24T09:34:08Z

@peterzhongyi For additional guidance, refer to PR #3663, where Mark provided helpful suggestions that I have followed closely.

agones-bot · 2024-11-06T17:08:54Z

Build Succeeded 🥳

Build Id: 126b88be-5d05-44c5-a174-bacf455d4d48

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-0a00781
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-0a00781
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-0a00781-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-0a00781
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-0a00781
Linux C++ SDK (build): agonessdk-1.45.0-dev-0a00781-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-0a00781.zip

A preview of the website (the last 30 builds are retained):

https://0a00781-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-0a00781

gongmax · 2024-11-06T17:49:18Z

@0xaravindh would you like to test your change by following https://agones.dev/site/docs/guides/metrics/#installation to install prometheus and grafana locally and see whether the new added metrics shows up?

agones-bot · 2024-11-06T20:58:28Z

Build Failed 😭

Build Id: e9783c89-b541-41e5-be81-aca7e55b611c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2024-11-11T06:01:07Z

@0xaravindh would you like to test your change by following https://agones.dev/site/docs/guides/metrics/#installation to install prometheus and grafana locally and see whether the new added metrics shows up?

@gongmax I’ve tested it by following the guide to install Prometheus and Grafana locally, and the new metrics are showing up correctly in gs dashboard. do you think stats are looking enough? or should I include any additional data in that field?

vicentefb · 2024-11-18T21:23:36Z

lgtm

agones-bot · 2024-11-18T22:27:35Z

Build Succeeded 🥳

Build Id: 45f2502f-6f05-4c76-a861-2bb146e1877c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-2a221cb
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-2a221cb
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-2a221cb-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-2a221cb
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-2a221cb
Linux C++ SDK (build): agonessdk-1.45.0-dev-2a221cb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-2a221cb.zip

A preview of the website (the last 30 builds are retained):

https://2a221cb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-2a221cb

agones-bot · 2024-11-18T23:26:53Z

Build Succeeded 🥳

Build Id: 786cb00a-b47b-4188-ad9d-0848fbd35c5f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-0c91fa9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-0c91fa9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-0c91fa9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-0c91fa9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-0c91fa9
Linux C++ SDK (build): agonessdk-1.45.0-dev-0c91fa9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-0c91fa9.zip

A preview of the website (the last 30 builds are retained):

https://0c91fa9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-0c91fa9

…4021) * Add metric for agones_fleets_active_gameserverset_percentage calculation * lint fixed --------- Co-authored-by: Mengye (Max) Gong <[email protected]> Co-authored-by: Vicente Ferrara <[email protected]>

Add metric for agones_fleets_active_gameserverset_percentage calculation

a2a5027

github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Oct 23, 2024

lint fixed

000872c

0xaravindh requested review from igooch, markmandel and gongmax October 23, 2024 15:43

igooch requested a review from peterzhongyi October 23, 2024 16:52

Merge branch 'main' into gss-metrics

0a00781

Merge branch 'main' into gss-metrics

60f62ab

0xaravindh requested a review from vicentefb November 13, 2024 17:23

Merge branch 'main' into gss-metrics

2a221cb

vicentefb enabled auto-merge (squash) November 18, 2024 21:23

vicentefb approved these changes Nov 18, 2024

View reviewed changes

Merge branch 'main' into gss-metrics

0c91fa9

vicentefb merged commit 244f501 into googleforgames:main Nov 18, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Fleet Active GameServerSet Percentage Metrics #4021

Adding Fleet Active GameServerSet Percentage Metrics #4021

0xaravindh commented Oct 23, 2024

agones-bot commented Oct 23, 2024

agones-bot commented Oct 23, 2024

peterzhongyi commented Oct 23, 2024 •

edited

Loading

0xaravindh commented Oct 24, 2024

agones-bot commented Nov 6, 2024

gongmax commented Nov 6, 2024

agones-bot commented Nov 6, 2024

0xaravindh commented Nov 11, 2024 •

edited

Loading

vicentefb commented Nov 18, 2024

agones-bot commented Nov 18, 2024

agones-bot commented Nov 18, 2024

Adding Fleet Active GameServerSet Percentage Metrics #4021

Adding Fleet Active GameServerSet Percentage Metrics #4021

Conversation

0xaravindh commented Oct 23, 2024

agones-bot commented Oct 23, 2024

agones-bot commented Oct 23, 2024

peterzhongyi commented Oct 23, 2024 • edited Loading

0xaravindh commented Oct 24, 2024

agones-bot commented Nov 6, 2024

gongmax commented Nov 6, 2024

agones-bot commented Nov 6, 2024

0xaravindh commented Nov 11, 2024 • edited Loading

vicentefb commented Nov 18, 2024

agones-bot commented Nov 18, 2024

agones-bot commented Nov 18, 2024

peterzhongyi commented Oct 23, 2024 •

edited

Loading

0xaravindh commented Nov 11, 2024 •

edited

Loading