Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SIDECAR_IMAGE tag in Helm chart variable #4020

Closed
wants to merge 18 commits into from
Closed

Update SIDECAR_IMAGE tag in Helm chart variable #4020

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fcf04a2
Update SIDECAR_IMAGE tag in Helm chart variable
0xaravindh Oct 22, 2024
fd54613
Allowing list based fleet autoscaler to scale up from 0 replicas (#4016)
geopaulm Oct 31, 2024
23bbb0c
Write Terraform scripts and docs to show how to create OKE cluster an…
ouxingning Nov 2, 2024
18ec7b9
Update Supported Kubernetes to 1.29, 1.30, 1.31 (#4024)
kamaljeeti Nov 5, 2024
cf428cc
created performance cluster 1.30 (#4031)
kamaljeeti Nov 6, 2024
ac3c445
Dashboard for Agones GameServer State duration (#3947)
vicentefb Nov 6, 2024
3893193
Add Shutdown Delay Seconds to the containers (#4030)
igooch Nov 7, 2024
be7aed4
Add a CI check to fail on change to an example without a new version …
wheatear-dev Nov 7, 2024
c5939bf
Updates the upgrade terraform to the latest k8s version and removes t…
igooch Nov 18, 2024
e90b37b
Adding Fleet Active GameServerSet Percentage Metrics (#4021)
0xaravindh Nov 18, 2024
907f90a
Introducing Agones Guru on Gurubase.io (#4028)
kursataktas Nov 19, 2024
2b7baf7
update cpp-simple example tag to 0.19 (#4040)
kamaljeeti Nov 19, 2024
5965235
Release v1.45.0 (#4041)
0xaravindh Nov 19, 2024
3ecda34
Preparation for Release v1.46.0 (#4043)
0xaravindh Nov 20, 2024
a5e77a2
Update image tag in cpp-simple example (#4044)
0xaravindh Nov 21, 2024
82c98ef
Correct CI check for examples and add unit test (#4045)
wheatear-dev Nov 21, 2024
dd7b0e7
Changes upgrades clusters to use only us based regions (#4046)
igooch Nov 21, 2024
099c2b8
created separate tag for agones-sidecar
0xaravindh Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/helm/agones/templates/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
value: {{ .Values.gameservers.additionalPortRanges | toJson | quote }}
{{- end }}
- name: SIDECAR_IMAGE # overwrite the GameServer sidecar image that is used
value: "{{ .Values.agones.image.registry }}/{{ .Values.agones.image.sdk.name}}:{{ default .Values.agones.image.tag .Values.agones.image.sdk.tag }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what was asking for is expose a variable to set the registry for SIDECAR_IMAGE separately rather than using agones.image.registry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user has provided a comment regarding the same queries. (#3979 (comment))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and what user asked "This is why I proposed the option to modify the registry for the SDK image." aligns with what I proposed above.

value: "{{ .Values.agones.image.registry }}/{{ .Values.agones.image.sdk.name}}:{{ .Values.agones.image.sdk.tag }}"
- name: ALWAYS_PULL_SIDECAR # set the sidecar imagePullPolicy to Always
value: {{ .Values.agones.image.sdk.alwaysPull | quote }}
- name: SIDECAR_CPU_REQUEST
Expand Down
1 change: 1 addition & 0 deletions install/helm/agones/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ agones:
pullPolicy: IfNotPresent
sdk:
name: agones-sdk
tag: 1.45.0-dev
cpuRequest: 30m
cpuLimit: 0
memoryRequest: 0
Expand Down
Loading