Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard for Agones GameServer State duration #3947

Merged

Conversation

vicentefb
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
There's no dashboard in Grafana for agones_gameserver_state_duration metric

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/M labels Aug 13, 2024
@vicentefb
Copy link
Collaborator Author

image

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a200c7f4-cecc-468b-87e4-7d537bc449f8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0e8c697c-de14-46e2-85d4-8c97469c470b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-3a0e864

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 83cfc58c-f55d-4c91-b4ff-34feba5987b7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 33716bfe-8b0f-4101-a648-9c49127bbc13

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b0d475b

@markmandel
Copy link
Member

Just tried installing this, and I no longer see the the dashboard for "Agones Gameservers", so there's something not quite right with the ConfigMap export.

image

Did you test reimporting the dashboard? 🤔

@markmandel
Copy link
Member

Forgot to ask, which versions of prom and grafana are you running?

❯ helm ls -a -n metrics
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION
grafana metrics         2               2024-08-16 10:52:53.523460868 +0000 UTC deployed        grafana-8.4.4           11.1.3
prom    metrics         3               2024-08-16 08:26:53.823474912 +0000 UTC deployed        prometheus-25.26.0      v2.54.0

That's what I have installed.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 42c93c05-1644-444f-bc8e-7b0759c5ff18

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-94b646f

@gongmax gongmax self-requested a review August 19, 2024 22:03
build/grafana/dashboard-gameservers.yaml Outdated Show resolved Hide resolved
build/grafana/dashboard-gameservers.yaml Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 6cddafe5-5166-4050-9593-c44920d0a4ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-4eae250

@vicentefb vicentefb force-pushed the AddGameServerStateDurationToGrafana branch from 4eae250 to 8024f0b Compare August 21, 2024 06:44
@vicentefb vicentefb requested a review from gongmax August 21, 2024 06:52
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c3ba88cc-039d-45fd-86fe-f5c7dd462741

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-7164d3f

@gongmax
Copy link
Collaborator

gongmax commented Aug 21, 2024

I can see the the dashboard for "Agones Gameservers" using the ConfigMaps in this PR. Looking at @markmandel 's screenshot, dashboard for "Agones Allocator Resource" is also missing. I'm gonna leave this to @vicentefb and @markmandel to figure out what's wrong.

image

@gongmax
Copy link
Collaborator

gongmax commented Aug 21, 2024

My versions of prom and grafana

> helm ls -a -n metrics 
NAME   	NAMESPACE	REVISION	UPDATED                                	STATUS  	CHART             	APP VERSION
grafana	metrics  	1       	2024-08-21 22:38:16.319785651 +0000 UTC	deployed	grafana-8.4.6     	11.1.4
prom   	metrics  	1       	2024-08-21 22:35:52.031204554 +0000 UTC	deployed	prometheus-25.26.0	v2.54.0

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e9ea72c3-d9b3-4c23-973b-769918f45be7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-774877d

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ba4b961e-a943-4f0b-9a70-f3a6fa7f0c13

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-41ff92e

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 37b79bbd-8810-468d-b3d8-852649992c9d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-396bee7

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 35ab335e-8ac4-41e0-9a2d-44a4fd21f765

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 38b57e55-8f7b-4366-81d8-57c3b3dc9175

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-61d5c12

@vicentefb
Copy link
Collaborator Author

friendly ping @markmandel

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: bed61055-401a-45cf-acd3-aea1a4cef01e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-b55fcfc

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2dac926b-7c10-467c-adf5-630e406b712e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-1f66af1

Copy link

github-actions bot commented Oct 8, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 9410f234-83cc-419a-928c-7b71532281aa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-91d68d4

Copy link

github-actions bot commented Nov 6, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@gongmax
Copy link
Collaborator

gongmax commented Nov 6, 2024

@markmandel do you still want to take a look at this?

@markmandel
Copy link
Member

Not if someone else has 👍🏻 sorry about that!

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: b2428002-303e-4e81-9176-db946dc7b225

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-a0264ca

@vicentefb vicentefb merged commit 6e6fe5d into googleforgames:main Nov 6, 2024
4 checks passed
0xaravindh pushed a commit to 0xaravindh/agones that referenced this pull request Nov 26, 2024
* added dashboard for agones gameserver state duration

* lint

* updated json

* lint

* changed the UID and reimporting works

* nit

* reverted UID change

---------

Co-authored-by: Mengye (Max) Gong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/M size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants