Skip to content

Commit

Permalink
Changes upgrades clusters to use only us based regions (#4046)
Browse files Browse the repository at this point in the history
  • Loading branch information
igooch authored and 0xaravindh committed Nov 26, 2024
1 parent 82c98ef commit dd7b0e7
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions build/terraform/upgrade/module.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,27 +38,25 @@ variable "kubernetes_versions" {
description = "Create upgrade test clusters with these k8s versions in these regions"
type = map(list(string))
default = {
"1.29" = ["europe-west1", "RAPID"]
"1.30" = ["asia-east1", "RAPID"]
"1.29" = ["us-west1", "RAPID"]
"1.30" = ["us-central1", "RAPID"]
"1.31" = ["us-east1", "RAPID"]
//1.32" = ["us-west1", "RAPID"]
//
// Before merge: When adding Kubernetes version 1.{N}, first uncomment the line above, extending
// the infrastructure to 4 versions temporarily. Come back to these instructions after the
// update PR merges.
// Before merge: When adding Kubernetes version 1.{N}, first uncomment the line above. Come back
// to these instructions after the update PR merges.
//
// After merge: After the Kubernetes update PR merges, and all active PRs are updated:
//
// * Move the 1.{N-3} line to the bottom and comment it out
// * Change the (commented out) 1.{N-3} to 1.{N+1}
// * You should now have 3 versions uncommented (versions 1.{N-2} .. 1.{N}),
// and 1.{N+1} commented out for the next update. The new, commented out 1.{N+1}
// should be using the region of the previous 1.{N-3} - this region will become
// unused.
// should be using the region of the current 1.{N-3}.
//
// Rationale: We cycle the regions us-east1 -> us-west1 -> europe-west1 -> asia-east1 -> us-east1
// as versions are added, using 4 regions so that the PR adding 1.{N} is in a unique region to
// 1.{N-3} .. 1.{N-1}, meaning versions never need to share a region in CI.
// Rationale: We cycle the regions us-east1 -> us-west1 -> us-central1 -> us-east1 as versions
// are added, using 3 regions so that the PR adding 1.{N} is in a unique region to
// 1.{N-2} .. 1.{N-1}, meaning versions never need to share a region in CI.
}
}

Expand Down

0 comments on commit dd7b0e7

Please sign in to comment.