Skip to content

Commit

Permalink
Updates the upgrade terraform to the latest k8s version and removes t…
Browse files Browse the repository at this point in the history
…he firewall rules from the upgrade terraform as they already exists as part of the e2e terraform, and will conflict. (#4036)
  • Loading branch information
igooch authored Nov 18, 2024
1 parent 10a8bca commit 5083d8d
Showing 1 changed file with 31 additions and 29 deletions.
60 changes: 31 additions & 29 deletions build/terraform/upgrade/module.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ variable "kubernetes_versions" {
description = "Create upgrade test clusters with these k8s versions in these regions"
type = map(list(string))
default = {
"1.28" = ["us-west1", "RAPID"]
"1.29" = ["europe-west1", "RAPID"]
"1.30" = ["asia-east1", "RAPID"]
// "1.31" = ["us-east1", "RAPID"]
"1.31" = ["us-east1", "RAPID"]
//1.32" = ["us-west1", "RAPID"]
//
// Before merge: When adding Kubernetes version 1.{N}, first uncomment the line above, extending
// the infrastructure to 4 versions temporarily. Come back to these instructions after the
Expand Down Expand Up @@ -80,30 +80,32 @@ module "gke_autopilot_cluster" {
releaseChannel = each.value[1]
}

resource "google_compute_firewall" "udp" {
name = "gke-game-server-firewall"
project = var.project
network = "default"

allow {
protocol = "udp"
ports = ["7000-8000"]
}

target_tags = ["game-server"]
source_ranges = ["0.0.0.0/0"]
}

resource "google_compute_firewall" "tcp" {
name = "gke-game-server-firewall-tcp"
project = var.project
network = "default"

allow {
protocol = "tcp"
ports = ["7000-8000"]
}

target_tags = ["game-server"]
source_ranges = ["0.0.0.0/0"]
}
// NOTE: These are the same firewall rules as the e2e tests. If running only the upgrade clusters on
// a new project the clusters will need these rules.
// resource "google_compute_firewall" "udp" {
// name = "gke-game-server-firewall"
// project = var.project
// network = "default"
//
// allow {
// protocol = "udp"
// ports = ["7000-8000"]
// }
//
// target_tags = ["game-server"]
// source_ranges = ["0.0.0.0/0"]
//}
//
// resource "google_compute_firewall" "tcp" {
// name = "gke-game-server-firewall-tcp"
// project = var.project
// network = "default"
//
// allow {
// protocol = "tcp"
// ports = ["7000-8000"]
// }
//
// target_tags = ["game-server"]
// source_ranges = ["0.0.0.0/0"]
//}

0 comments on commit 5083d8d

Please sign in to comment.