[ttx_diff]: Normalize kern rules #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Jan 17, 2024
layout-normalizer/src/gpos.rs
Outdated
Comment on lines
246
to
248
| // - if we have device tables we're just dropping the second, which | ||
| // is fine for our purposes? And if we have mixed deltas & devices than | ||
| // god help us |
There was a problem hiding this comment.
this is fine, I've actually never seen device tables in the wild. how about we at least warn?
There was a problem hiding this comment.
we can warn, but when we run with ttx_diff (which is the most common case) we suppress stderr so we might never see it. 🤔
There was a problem hiding this comment.
This is an internal tool, and we don't use device tables, so I'm just going to let this slide.
anthrotype
reviewed
Jan 17, 2024
anthrotype
approved these changes
Jan 18, 2024
With this we will now combine any pairpos rules that apply to the same glyph pair in different lookups into a single value, as would happen with a shaper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the proper normalization logic for pairpos rules: basically we will now sum the values in subsequent lookups that apply to the same pairs.
this PR also involves moving some test helpers to a common
test_helpersmodule, since they're needed by different tests that live in different places.There's one question inline: basically I'm not sure how we should think about merging of device tables, or if we should care. Also I'm assuming that if deltas are provided there should be the same number of deltas in each master, and we can just sum them individually?