Add MVAR test files exercising all global metrics #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'MVAR Test' VF (in Glyphs3, Glyphs2 and DS formats) has one 'slnt' axis and 3 masters, one upright (default) and two back- and forward-slanted masters; in the backslanted master, all the variable global metrics are shifted -5, in the forward-slanted master they are shifted +5 (this to simplify testing). The purpose of the test files is to make sure that all the global metrics defined in the source files make it to the MVAR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes an 'MVAR Test' VF in Glyphs3, Glyphs2 and DesignSpace formats to be used for testing #648.
I separated this to avoid that other PR to get too noisy. This one is expected to be merged first, as the other depends on it for the tests.
The VF has one 'slnt' axis and 3 masters, one upright (default) and two backward- and forward-slanted masters; in the back-slanted master, all the variable global metrics are shifted by -5 units, in the forward-slanted master they are shifted +5 (the numbers don't make sense from a design POV it's just to simplify testing).
The purpose of the test files is to make sure that all the global metrics defined in the source files make it to the MVAR.
The reason the DS/UFO sources are not auto-generated from the .glyphs ones is because there are some variable global metrics that can be set in UFO fontinfo.plist but cannot be overridden in .glyphs sources: i.e. the hhea caret slope rise/run/offset; in Glyphs, these are always derived based on the italic angle and can't be controlled directly.
JMM