Add initial implementation of meta compilation
#1136
Draft
+284
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is sufficient to resolve a few ttx table diffs on fontc_crater, but needs refinement.
This is heavily WIP; it needs a tidy and is untested, and should be considered an initial draft only.
|
(rebased on |
rsheeter
reviewed
Nov 21, 2024
| .collect(), | ||
| )) | ||
| } | ||
| }; |
There was a problem hiding this comment.
This looks like it should be possible to unindent, e.g.
let static_metadata = context.ir.static_metadata.get();
let records = &static_metadata.misc.meta;
// Guard clause: nop if there are no meta records
if records.is_empty() {
return Ok(());
}
context.meta.set(Meta::new(...));
rsheeter
reviewed
Nov 21, 2024
| @@ -130,6 +134,8 @@ impl GlyphsIrSource { | |||
| unicode_range_bits: font.unicode_range_bits.clone(), | |||
| codepage_range_bits: font.codepage_range_bits.clone(), | |||
| panose: font.panose.clone(), | |||
| // TODO: Is this correct? | |||
rsheeter
reviewed
Nov 21, 2024
| @@ -182,6 +188,8 @@ impl GlyphsIrSource { | |||
| unicode_range_bits: None, | |||
| codepage_range_bits: None, | |||
| panose: None, | |||
| // TODO: Is this correct? | |||
There was a problem hiding this comment.
looks right, I don't think meta can change global metrics
rsheeter
reviewed
Nov 21, 2024
| // TODO: This diverges from glyphsLib, which must convert a list of | ||
| // records into UFO's intermediate dict representation; is this | ||
| // actually an improvement, or a breaking change? What does Glyphs | ||
| // do? |
There was a problem hiding this comment.
this seems like an @anthrotype question
|
I'm sorry, I somehow missed this PR and went and impl'd this for glyphs sources in #1160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR begins implementation of
metatable compilation for the Glyphs and UFO formats. This is a larger end-to-end implementation than my previous PRs, and so I am making an early draft to work on it publicly to make sure that it can be shaped from the beginning, and that it stays on track; all feedback and contributions welcome :)Implemented
metatable for the top few fontc_crater reportsTODO
StateSetconstruction inglyphs2fontirexpect(...), no type conversion clutter, etc)main(most of these are also flagged as inline TODOs, to be resolved before merge)
Will implement #1113
Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction