Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add client side logging with slf4j #3403
base: main
Are you sure you want to change the base?
feat: add client side logging with slf4j #3403
Changes from 10 commits
59b5d73
d34ec88
b6417ae
0c169ad
9ced175
681f7d5
5c01ef2
6605ef3
ebbae15
543298d
aac66f2
487614c
cc3465b
211a3d1
2970210
32f8b7c
245c14d
8358497
97087b2
727a3e9
23bc111
bbe0700
3d7c7f9
b870d81
56a2870
83eedf0
d85c848
1919809
613b6c8
1169eaa
a6b5433
fb0966e
77939fe
04ef774
439e071
673c9fe
c2b607b
3df39fa
4190dc7
fefb436
7901d8a
20f9f5a
172701d
d25e742
a8d2f20
df97834
32dbd0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be package private. Same thing for
HttpJsonLoggingInterceptor
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current test setup, these needs to be public for testing purposes. I'll look into the test setup again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
requestId
is for debugging purpose for now and would be removed later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for now. Later when we also log in tracer, we may need some requestID to track (not this one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gRPC metadata could be binary, see https://grpc.io/docs/guides/metadata/. I'm not sure if this is going to fail or not if the value is binary, can you test it out? Either way, I think we should exclude binary headers as they don't provide much value.