Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Resolve connections deprecation warning #1310

Merged
merged 3 commits into from
Jan 3, 2025
+2 −4
Merged

tests: Resolve connections deprecation warning #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
577ee9f
Fix (#1206) connections deprecation warning
xionams Dec 3, 2024
db06bee
clean up
parthea Jan 3, 2025
f5f1474
Merge branch 'main' into main
parthea Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,3 @@ filterwarnings =
# Remove once the minimum supported version of googleapis-common-protos is 1.62.0
ignore:.*pkg_resources.declare_namespace:DeprecationWarning
ignore:.*pkg_resources is deprecated as an API:DeprecationWarning
# Remove once https://github.com/googleapis/python-pubsub/issues/1206 is fixed.
ignore:.*connections\(\) is deprecated and will be removed; use net_connections\(\) instead:DeprecationWarning
4 changes: 2 additions & 2 deletions tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def test_subscriber_not_leaking_open_sockets(
publisher.create_topic(name=topic_path)

current_process = psutil.Process()
conn_count_start = len(current_process.connections())
conn_count_start = len(current_process.net_connections())

# Publish a few messages, then synchronously pull them and check that
# no sockets are leaked.
Expand All @@ -487,7 +487,7 @@ def test_subscriber_not_leaking_open_sockets(
response = subscriber.pull(subscription=subscription_path, max_messages=3)
assert len(response.received_messages) == 3

conn_count_end = len(current_process.connections())
conn_count_end = len(current_process.net_connections())

# To avoid flakiness, use <= in the assertion, since on rare occasions additional
# sockets are closed, causing the == assertion to fail.
Expand Down
Loading