Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require proto-plus >= 1.25 for Python 3.13 #955

Merged
merged 3 commits into from
Nov 21, 2024
Merged

fix: require proto-plus >= 1.25 for Python 3.13 #955

merged 3 commits into from
Nov 21, 2024

Conversation

gkevinzheng
Copy link
Contributor

Fixes #944

@gkevinzheng gkevinzheng requested review from a team as code owners November 20, 2024 19:42
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 20, 2024
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 20, 2024
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@gkevinzheng gkevinzheng enabled auto-merge (squash) November 20, 2024 21:12
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
gkevinzheng added a commit that referenced this pull request Nov 21, 2024
@gkevinzheng
fix: require proto-plus >= 1.25 for Python 3.13 (#955)
002b1fc 
+
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Nov 21, 2024
@gkevinzheng gkevinzheng disabled auto-merge November 21, 2024 16:01
@gkevinzheng gkevinzheng merged commit 7baed8e into main Nov 21, 2024
16 checks passed
@gkevinzheng gkevinzheng deleted the proto-plus-fix branch November 21, 2024 16:57
@release-please release-please bot mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkim-codes kevkim-codes kevkim-codes approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche was automatically assigned from googleapis/api-logging

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/python-logging API. size: u Pull request is empty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proto-plus >= 1.25 needed for python 3.13
5 participants
@gkevinzheng @kevkim-codes @yoshi-kokoro @cindy-peng @parthea