Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract nested list fields #786

Closed
wants to merge 2 commits into from
Closed

Conversation

daniel-sanche
Copy link
Contributor

When running set with a list of fields, the list wasn't being iterated properly, leading to potential crashes.

This PR resolves the issue by properly iterating over lists in extract_fields

Fixes #665

@daniel-sanche daniel-sanche requested review from a team as code owners October 23, 2023 23:46
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 23, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/python-firestore API. labels Oct 23, 2023
@daniel-sanche
Copy link
Contributor Author

Closed as intended behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELETE_FIELD not working in a map inside a list
1 participant