[DRAFT] chore: use cross sync for async methods #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
daniel-sanche
changed the title
This reverts commit 245bd08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - Adding polish - Not ready for review
PR 1/3 for adding the sync surface for the new data client
This PR restructures the existing async library to better support the sync side. Specifically, all async-specific calls and types are replaced with corresponding calls to the new CrossSync class, which simply contains a set of aliases pointing back at the corresponding async functionality
While reviewing this PR, focus on the readability of the async code.
In a future PRs, we will introduce a corresponding synchronous implementation of CrossSync, and a code generator that produces sync code from this async copy.
TODO: