Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update templated files #986

Merged
merged 15 commits into from
Jul 17, 2024
Merged

chore: update templated files #986

merged 15 commits into from
Jul 17, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 5, 2024

No description provided.

@parthea parthea requested review from a team as code owners July 5, 2024 14:41
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 5, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea marked this pull request as draft July 5, 2024 15:30
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 5, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2024
@parthea parthea marked this pull request as ready for review July 5, 2024 16:16
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 5, 2024 16:18
@gcf-owl-bot gcf-owl-bot bot requested a review from kweinmeister July 5, 2024 16:18
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jul 5, 2024
daniel-sanche
daniel-sanche requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is removing some important owlbot customizations. I'll push a fix

@parthea
Copy link
Contributor Author

parthea commented Jul 17, 2024

Good catch ! I see that now

parthea
parthea commented Jul 17, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2024
@parthea parthea merged commit 481c8d6 into main Jul 17, 2024
24 of 32 checks passed
@parthea parthea deleted the parthea-patch-1 branch July 17, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@kweinmeister kweinmeister Awaiting requested review from kweinmeister kweinmeister is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@mutianf mutianf

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @daniel-sanche @mutianf