feat: improve async sharding #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: m
daniel-sanche
changed the title
igorbernstein2
approved these changes
Jun 10, 2024
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
igorbernstein2
approved these changes
Jun 11, 2024
| @@ -755,6 +755,10 @@ async def read_rows_with_semaphore(query): | |||
| async with concurrency_sem: | |||
| # calculate new timeout based on time left in overall operation | |||
| shard_timeout = next(rpc_timeout_generator) | |||
| if shard_timeout <= 0: | |||
| raise DeadlineExceeded( | |||
| "Operation timeout exceeded before starting query" | |||
There was a problem hiding this comment.
maybe before starting subquery?
There was a problem hiding this comment.
This is the earliest we can check after getting through the semaphore.
There is a similar check at the very beginning as part of _get_timeouts though (which raises an AttributeError)
daniel-sanche
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a semaphore to control shard concurrency, rather than discrete batches