feat: add cloud workflow for exporting vector data from Bigtable to Vertex Vector Search #930
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: xl
ron-gal
changed the title
daniel-sanche
changed the title
| ) | ||
|
|
||
| # Make the request | ||
| operation = workflow_client.delete_workflow(request=request) |
There was a problem hiding this comment.
Can you put this in a try/finally block? I want to make sure it is being cleaned up properly, even if it exits early
| } | ||
| ) | ||
|
|
||
| logger.info("Created {} table on instance {}.".format(table_name, instance_id)) |
There was a problem hiding this comment.
Is the table being cleaned up properly on completion?
There was a problem hiding this comment.
Yes, everywhere this function is called it is followed by cleanup_bigtable_resources. Added try\finally in the one place it was missing, to ensure it happens.
|
I'm not sure this is the right place for this kind of content. Usually, the I'd probably suggest moving the contents of this README to a page on the docsite, pulling in some snippets like this one to show how to interact with it using Python, and linking to that page in the README here. But let me know if you've already considered that |
|
Merged in GoogleCloudPlatform/workflows-demos#114 |
…x Vector Search
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This is a Bigtable version of https://github.com/cloudspannerecosystem/spanner-ai. Most of the work was copy pasting the Spanner code and adjusting it for Bigtable.
Fixes #<issue_number_goes_here> 🦕