-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reversed scans #918
Conversation
This reverts commit 644d32e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a whole complicated state-machine in play here, so I don't think it's going to be quite this simple to get this feature working unfortunately (there are checks to make sure each row key is larger than the last one, for example)
If you're willing to take on the work of updating the state machine, the first step would probably be to add end-to-end system tests to this PR to ensure the output with reversed=True
matches what we'd expect to see.
But if you don't have the capacity to take that on, feel free to close this and I can get to it when I have a chance
ooh, unlucky. Okay, closing. Thanks! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕