Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reversed scans #918

Closed
wants to merge 11 commits into from

Conversation

ron-gal
Copy link

@ron-gal ron-gal commented Jan 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jan 16, 2024
@ron-gal ron-gal marked this pull request as ready for review January 23, 2024 15:18
@ron-gal ron-gal requested review from a team as code owners January 23, 2024 15:18
@ron-gal ron-gal requested a review from a team as a code owner February 6, 2024 20:10
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 6, 2024
This reverts commit 644d32e.
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Feb 6, 2024
@ron-gal ron-gal changed the title Support reversed scans fear: support reversed scans Feb 6, 2024
@ron-gal ron-gal changed the title fear: support reversed scans feat: support reversed scans Feb 6, 2024
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a whole complicated state-machine in play here, so I don't think it's going to be quite this simple to get this feature working unfortunately (there are checks to make sure each row key is larger than the last one, for example)

If you're willing to take on the work of updating the state machine, the first step would probably be to add end-to-end system tests to this PR to ensure the output with reversed=True matches what we'd expect to see.

But if you don't have the capacity to take that on, feel free to close this and I can get to it when I have a chance

@ron-gal
Copy link
Author

ron-gal commented Feb 8, 2024

There's a whole complicated state-machine in play here, so I don't think it's going to be quite this simple to get this feature working unfortunately (there are checks to make sure each row key is larger than the last one, for example)

If you're willing to take on the work of updating the state machine, the first step would probably be to add end-to-end system tests to this PR to ensure the output with reversed=True matches what we'd expect to see.

But if you don't have the capacity to take that on, feel free to close this and I can get to it when I have a chance

ooh, unlucky. Okay, closing. Thanks!

@ron-gal ron-gal closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants