Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TABLE_DEFAULTS enum for table method arguments #880

Merged
merged 13 commits into from
Oct 26, 2023
Merged

feat: add TABLE_DEFAULTS enum for table method arguments #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
561a7a0
added option for TABLE_DEFAULT
daniel-sanche Oct 20, 2023
2c479c2
changed code to use TABLE_DEFAULT
daniel-sanche Oct 20, 2023
2809d9d
clean up
daniel-sanche Oct 20, 2023
c24601b
use enum for table defaults
daniel-sanche Oct 20, 2023
b32d6bb
made TABLE_DEFAULTS public
daniel-sanche Oct 25, 2023
e31d765
fixed typing issues
daniel-sanche Oct 26, 2023
b7164e5
added docstring
daniel-sanche Oct 26, 2023
e8141e3
use enum values in attempt timeout calculation
daniel-sanche Oct 26, 2023
abb1bbe
added tests
daniel-sanche Oct 26, 2023
140743e
ran blacken
daniel-sanche Oct 26, 2023
bec98db
fixed mypy imports
daniel-sanche Oct 26, 2023
7334680
pin api-core version in prerelease-deps
daniel-sanche Oct 26, 2023
71d6274
ran black
daniel-sanche Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions google/cloud/bigtable/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#

from typing import List, Tuple

from google.cloud.bigtable import gapic_version as package_version

from google.cloud.bigtable.data._async.client import BigtableDataClientAsync
Expand Down Expand Up @@ -44,10 +41,10 @@
from google.cloud.bigtable.data.exceptions import MutationsExceptionGroup
from google.cloud.bigtable.data.exceptions import ShardedReadRowsExceptionGroup

# Type alias for the output of sample_keys
RowKeySamples = List[Tuple[bytes, int]]
# type alias for the output of query.shard()
ShardedQuery = List[ReadRowsQuery]
from google.cloud.bigtable.data._helpers import TABLE_DEFAULT
from google.cloud.bigtable.data._helpers import RowKeySamples
from google.cloud.bigtable.data._helpers import ShardedQuery


__version__: str = package_version.__version__

Expand All @@ -74,4 +71,5 @@
"MutationsExceptionGroup",
"ShardedReadRowsExceptionGroup",
"ShardedQuery",
"TABLE_DEFAULT",
)
Loading
Loading