chore: remove pooled transport #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
daniel-sanche
changed the title
mutianf
approved these changes
Nov 6, 2024
| transport_str = f"pooled_grpc_asyncio_{pool_size}" | ||
| transport = PooledBigtableGrpcAsyncIOTransport.with_fixed_size(pool_size) | ||
| BigtableClientMeta._transport_registry[transport_str] = transport | ||
| if "pool_size" in kwargs: |
There was a problem hiding this comment.
Could someone create a client with BigtableDataClientAsync("project-id", 3)?
There was a problem hiding this comment.
we discussed this offline, but the __init__() function includes a *, meaning only key-word arguments are allowed
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove grpc channel pooling functionality.
After some benchmarking, we found pooling provided little benefit in python, and it added significant complexity
Also removing the two submodules from this repo, as we no longer have any gapic changes that need to be pushed upstream