Skip to content

Commit

Permalink
fixed lint
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-sanche committed Nov 12, 2024
1 parent e0ab0b7 commit 0d7d7ea
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 1 addition & 3 deletions docs/scripts/patch_devsite_toc.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,7 @@ def validate_toc(toc_file_path, expected_section_list, added_sections):
# Add secrtions for the async_data_client and classic_client directories
toc_path = "_build/html/docfx_yaml/toc.yml"
custom_sections = [
TocSection(
dir_name="data_client", index_file_name="usage.rst"
),
TocSection(dir_name="data_client", index_file_name="usage.rst"),
TocSection(dir_name="classic_client", index_file_name="usage.rst"),
]
add_sections(toc_path, custom_sections)
Expand Down
1 change: 1 addition & 0 deletions google/cloud/bigtable/data/execute_query/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
Struct,
)
from google.cloud.bigtable.data._cross_sync import CrossSync

CrossSync.add_mapping("ExecuteQueryIterator", ExecuteQueryIteratorAsync)
CrossSync._Sync_Impl.add_mapping("ExecuteQueryIterator", ExecuteQueryIterator)

Expand Down
9 changes: 7 additions & 2 deletions tests/unit/data/test_sync_up_to_date.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

sync_files = list(convert_files_in_dir(repo_root))


def test_found_files():
"""
Make sure sync_test is populated with some of the files we expect to see,
Expand All @@ -42,7 +43,9 @@ def test_found_files():
assert "execute_query_iterator.py" in outputs
assert "test_client.py" in outputs
assert "test_system_autogen.py" in outputs, "system tests not found"
assert "client_handler_data_sync_autogen.py" in outputs, "test proxy handler not found"
assert (
"client_handler_data_sync_autogen.py" in outputs
), "test proxy handler not found"


@pytest.mark.skipif(
Expand All @@ -63,7 +66,9 @@ def test_sync_up_to_date(sync_file):
# compare by content
diff = unified_diff(found_render.splitlines(), new_render.splitlines(), lineterm="")
diff_str = "\n".join(diff)
assert not diff_str, f"Found differences. Run `nox -s generate_sync` to update:\n{diff_str}"
assert (
not diff_str
), f"Found differences. Run `nox -s generate_sync` to update:\n{diff_str}"
# compare by hash
new_hash = hashlib.md5(new_render.encode()).hexdigest()
found_hash = hashlib.md5(found_render.encode()).hexdigest()
Expand Down

0 comments on commit 0d7d7ea

Please sign in to comment.